Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the quotation handling implementation by making the NeedsQuoting function private and removing redundant test cases. This is a follow-up to PR #178 that cleans up the API surface and eliminates test duplication.
Key changes:
- Made
NeedsQuotingfunction private by renaming it toneedsQuoting, as it's only used internally byQuoteIdentifier - Removed the redundant
TestNeedsQuotingtest function, as the private function is fully tested throughTestQuoteIdentifier - Removed explicit reserved word test cases that were redundant with the dynamic test loop
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ir/quote.go | Renamed NeedsQuoting to needsQuoting to make it a private function |
| ir/quote_test.go | Removed TestNeedsQuoting function and redundant explicit reserved word test cases from TestQuoteIdentifier |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup #178